Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistics websocket endpoint #51044

Merged
merged 2 commits into from
May 25, 2021
Merged

Add statistics websocket endpoint #51044

merged 2 commits into from
May 25, 2021

Conversation

bramkragten
Copy link
Member

Proposed change

Add websocket command to get statistics data.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration (history) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved May 24, 2021
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok after test added.

end_time,
msg.get("statistic_id"),
)
connection.send_result(msg["id"], {"statistics": statistics})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How big will this data be? Should it use await connection.send_big_result(…) instead?

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's keep it like this for now, if we see problems we can change to using send_big_result.

@balloob balloob merged commit f4dc72c into dev May 25, 2021
Dev automation moved this from Reviewer approved to Done May 25, 2021
@balloob balloob deleted the add-statistics-ws-endpoint branch May 25, 2021 15:14
bdraco pushed a commit to bdraco/home-assistant that referenced this pull request May 25, 2021
Co-authored-by: Erik <erik@montnemery.com>
bdraco pushed a commit to bdraco/home-assistant that referenced this pull request May 25, 2021
Co-authored-by: Erik <erik@montnemery.com>
bdraco pushed a commit to bdraco/home-assistant that referenced this pull request May 25, 2021
Co-authored-by: Erik <erik@montnemery.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants