Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only debug log new Sonos SSDP discoveries #51247

Merged
merged 4 commits into from May 31, 2021

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented May 29, 2021

Proposed change

The new SSDP discovery method provides useful information in the SSDP payloads, but it also prints them every loop. This changes so that we only print the discovery payload the first time we see a speaker, or when it has been re-discovered after being marked away.

If there are intermittent connectivity issues with a speaker we won't see the payloads when they're re-discovered, but I think that's acceptable.

cc: @bdraco

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as its been labeled with an integration (sonos) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@jjlawren jjlawren changed the title Only debug log new SSDP discoveries Only debug log new Sonos SSDP discoveries May 29, 2021
Dev automation moved this from Needs review to Reviewer approved May 29, 2021
Co-authored-by: J. Nick Koston <nick@koston.org>
@jjlawren jjlawren merged commit 1a5d35d into home-assistant:dev May 31, 2021
Dev automation moved this from Reviewer approved to Done May 31, 2021
@jjlawren jjlawren deleted the sonos_new_ssdp_debug branch May 31, 2021 01:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants