Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HAP-python to 3.5.0 #51261

Merged
merged 3 commits into from May 31, 2021
Merged

Upgrade HAP-python to 3.5.0 #51261

merged 3 commits into from May 31, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 30, 2021

Proposed change

  • Fixes executor overload during startup

  • Fixes another case of accessories going unavailable

  • Fixes for malformed event sending

  • Performance improvements

Changes: ikalchev/HAP-python@v3.4.1...v3.5.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- Fixes for malformed event sending

- Performance improvements
@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label May 30, 2021
@project-bot project-bot bot added this to Needs review in Dev May 30, 2021
@bdraco bdraco changed the title Upgrade HAP-python to 3.4.2 Upgrade HAP-python to 3.5.0 May 31, 2021
@bdraco bdraco added this to the 2021.6.0 milestone May 31, 2021
@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label May 31, 2021
@bdraco bdraco marked this pull request as ready for review May 31, 2021 16:47
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 馃憤

Dev automation moved this from Needs review to Reviewer approved May 31, 2021
@frenck frenck merged commit 0e7c2cd into home-assistant:dev May 31, 2021
Dev automation moved this from Reviewer approved to Done May 31, 2021
balloob pushed a commit that referenced this pull request May 31, 2021
* Upgrade HAP-python to 3.4.2

- Fixes for malformed event sending

- Performance improvements

* Bump

* update tests to point to async
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants