Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve deCONZ lights supported_color_modes and tests #51933

Merged
merged 3 commits into from Jun 22, 2021

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jun 16, 2021

Breaking change

Proposed change

Follow up PR to #51656, where test coverage declined.
Library change Kane610/deconz@v79...v80 (only PR 123 affects functionality).

Improve reflecting light state changes to relevant groups in library. Previously only one lights supported features would be read, after this change all lights connected to the group will be considered. This means a group can better reflect different types of lights together, earlier a group could be seen as only supporting brightness even though it also had a light supporting XY color mode.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 requested a review from emontnemery June 16, 2021 18:08
@project-bot project-bot bot added this to Needs review in Dev Jun 16, 2021
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Jun 17, 2021
@Kane610 Kane610 marked this pull request as ready for review June 17, 2021 15:40
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tests/components/deconz/test_light.py Show resolved Hide resolved
Dev automation moved this from Incoming to Reviewer approved Jun 22, 2021
@Kane610 Kane610 merged commit 6814e96 into home-assistant:dev Jun 22, 2021
Dev automation moved this from Reviewer approved to Done Jun 22, 2021
@Kane610 Kane610 deleted the deconz-improve_light_tests branch June 22, 2021 17:30
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants