Add Color Palette Select entities to WLED #51994
Conversation
probot-home-assistant
bot
added
has-tests
integration: wled
new-feature
by-code-owner
labels
|
The whole master light stuff of WLED bites me with this PR, as this palette entity only applies to segments, and segments can be dynamic. This means those segment lights and this select is appearing when segments are created, but also completely removed when the segment is removed. When this entity is disabled by default, testing the dynamic part becomes really problematic. As stuff, just all of a sudden disappears. This made me realize that this is not only really bad for testing, but also really bad for the user. Customizations on entities are fully lost is a segment is removed. This is not correct. Reworking that part now first, before finishing this one. |
|
Done. Updated with dev, the palette selects are available, but disabled by default. |
|
|
||
| # Process new segments, add them to Home Assistant | ||
| for segment_id in segment_ids - current_ids: | ||
| current[segment_id] = WLEDPaletteSelect(coordinator, segment_id) |
There was a problem hiding this comment.
There's no reason to store the entity. It's enough to store the segment id in a set.
There was a problem hiding this comment.
yeah, that is a nice more generic improvement, thanks! 馃憤
Proposed change
This adds the select platform to WLED, providing controls to select the color palette.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: