Fix missing azure event hub instance name #52049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
dependency
integration: azure_event_hub
small-pr
MartinHjelmare
changed the title
|
Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks! |
|
We should update the docs, right? https://www.home-assistant.io/integrations/azure_event_hub/#configuration-variables Please link a docs PR in this PR description. |
|
Yeah was already planning to do so! |
8 tasks
Done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Fix for using this component with IoTHub, event_hub_name is now a required field, can be filled by the DeviceID when using IoTHub.
Proposed change
Updated the package to azure-eventhub=5.5 (https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/eventhub/azure-eventhub/CHANGELOG.md).
Made a change in the config to fix the issue, now needs to include event_hub_name which has to be filled by the DeviceID when using IoTHub.
Added typing.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: