Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type annotations to Guardian #52598

Merged
merged 7 commits into from Jul 7, 2021

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 6, 2021

Proposed change

This PR adds missing type annotations to Guardian.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have bee

@bachya bachya self-assigned this Jul 6, 2021
@project-bot project-bot bot added this to Needs review in Dev Jul 6, 2021
homeassistant/components/guardian/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/guardian/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/guardian/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/guardian/config_flow.py Outdated Show resolved Hide resolved
homeassistant/components/guardian/config_flow.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Jul 6, 2021
bachya and others added 6 commits July 6, 2021 19:18
Co-authored-by: Shay Levy <levyshay1@gmail.com>
Co-authored-by: Shay Levy <levyshay1@gmail.com>
Co-authored-by: Shay Levy <levyshay1@gmail.com>
Co-authored-by: Shay Levy <levyshay1@gmail.com>
Co-authored-by: Shay Levy <levyshay1@gmail.com>
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bachya!

Dev automation moved this from Review in progress to Reviewer approved Jul 7, 2021
@bachya bachya merged commit 50d56fd into home-assistant:dev Jul 7, 2021
Dev automation moved this from Reviewer approved to Done Jul 7, 2021
tkdrob pushed a commit to tkdrob/core that referenced this pull request Jul 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2021
@bachya bachya deleted the guardian-types branch July 20, 2021 21:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants