Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't build Adafruit_BBIO - doesn't work on all platforms. #5281

Merged
merged 2 commits into from Jan 12, 2017
Merged

Don't build Adafruit_BBIO - doesn't work on all platforms. #5281

merged 2 commits into from Jan 12, 2017

Conversation

pavoni
Copy link
Contributor

@pavoni pavoni commented Jan 11, 2017

Description:
Fixes the OSX build (and I assume on some other platforms).

I think I did as suggested by @balloob

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):



Checklist:


If user exposed functionality or configuration variables are added/changed:



If the code communicates with devices, web services, or third-party tools:


    

  •  Local tests with tox run successfully. Your PR cannot be merged unless tests pass
    • 

  •  New dependencies have been added to the REQUIREMENTS variable (example).
    • 

  •  New dependencies are only imported inside functions that use them (example).
    • 

  •  New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
    • 

  •  New files were added to .coveragerc.
    • 



If the code does not interact with devices:


    

  •  Local tests with tox run successfully. Your PR cannot be merged unless tests pass
    • 

  •  Tests have been added to verify that the new code works.
    • 


    

  
  



      


          

          
  

    
  
  

  

  




          

        
      




  





      

       
            



      

  
        





      

  
      



  

  @mention-bot





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      



      

  


  

    

  





      


        


  
    

      
          
@pavoni, thanks for your PR! By analyzing the history of the files in this pull request, we identified @MatoKafkac, @balloob and @fabaff to be potential reviewers.

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          







      

  
      



  

  @pavoni





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  Author


  


  

    

      

      
          pavoni
  

      

      

      commented


        Jan 11, 2017


      
    


  





      


        


  
    

      
          
Looks like I got this slightly wrong. Any advice from the experts?


lint runtests: commands[1] | pylint homeassistant
************* Module homeassistant.components.bbb_gpio
E: 22, 4: Unable to import 'Adafruit_BBIO.GPIO' (import-error)
E: 38, 4: Unable to import 'Adafruit_BBIO.GPIO' (import-error)
E: 44, 4: Unable to import 'Adafruit_BBIO.GPIO' (import-error)
E: 51, 4: Unable to import 'Adafruit_BBIO.GPIO' (import-error)
E: 57, 4: Unable to import 'Adafruit_BBIO.GPIO' (import-error)
E: 63, 4: Unable to import 'Adafruit_BBIO.GPIO' (import-error)
ERROR: InvocationError: '/home/travis/build/home-assistant/home-assistant/.tox/lint/bin/pylint homeassistant'


      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
      



  

  @balloob





  


    

      

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
  Member


      

  


  

    

      

      
          balloob
  

      

      

      commented


        Jan 12, 2017


      
    


  





      


        


  
    

      
          
Add # pylint: disable=import-error

      		
    

  





        


            

              
            

        

      


      

            
  

    
  
  

  

  



    












      

  
          


  

  
  

  
      @pavoni
  pavoni


        force-pushed
    the
        
      
  fix_adafruit-bbio_failing_build


    
 branch
      2 times, most recently
    from
    
      8bcb577
    to
    
      e75fc7b
      
    Compare
  



    
      January 12, 2017 12:08
    
    









      

  
        

  

      

  MatoKafkac
  

  
          

            
                MatoKafkac
  

            

            reviewed


            
                
                  Jan 12, 2017
                
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
    

          

        
              homeassistant/components/bbb_gpio.py

        
      


    
        
  

    
    

          


              

              

            
                  import Adafruit_BBIO.GPIO as GPIO

            
          

          


              

              

            
                  GPIO.setup(pin, GPIO.OUT)

            
          

          


              

              

            
              


            		
          

          


              

              

            
              


            		
          

          


              

              

            
              def setup_input(pin, pull_mode):

            
          

          


              

              

            
                  """Setup a GPIO as input."""

            
          

          


              

              

            
                  import Adafruit_BBIO.GPIO as GPIO

            
          

    








  

    

        

        

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  


  

    

  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Why is this removed?

    

  
  



    


        

      
  

    
  
  

  

  




        

      
    





  

        

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  Author


  


  

    

  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Thanks Mato - mistake sorted!

    

  
  



    


        

      
  

    
  
  

  

  




        

      
    





  

        

  

    

        
    
    

  


      
          
    
            Copy link

      
    

  


  

      

      

  
    Contributor


      

  


  

    

  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Thanks to you for solving this issue!

    

  
  



    


        

      
  

    
  
  

  

  




        

      
    








    


  
















  








      

  
          

  
  

  
      @pavoni
  pavoni


        force-pushed
    the
        
      
  fix_adafruit-bbio_failing_build


    
 branch
    from
    
      e75fc7b
    to
    
      2e1a63b
      
    Compare
  



    
      January 12, 2017 12:56
    
    









      

  
        





      

  
          

  
  

  
      @pavoni
  pavoni


        force-pushed
    the
        
      
  fix_adafruit-bbio_failing_build


    
 branch
    from
    
      2e1a63b
    to
    
      db350b4
      
    Compare
  



    
      January 12, 2017 13:06
    
    




  

  

    
  

  



        @balloob
  balloob



        merged commit 9a3c0c8
      into

      
  
    dev
  


    Jan 12, 2017

  







  

  
  

  
      @balloob
  balloob


    
    deleted the
    
      
        fix_adafruit-bbio_failing_build
    
    branch

    
      January 12, 2017 16:31
    
    




  
  


  
    
  
  

    
  nordlead2005 

      added a commit
        to nordlead2005/home-assistant
      that referenced
      this pull request

    
      Jan 14, 2017
    
    

      


  

    

      


  

      
        @nordlead2005
  





      

        
          Revert "Bugfix camera streams (home-assistant#5306)"
        

          
            
          

      


      

          

    
    
    

  

      


      

      


      
      

        
          2ee8c44
        
      

    

  

    

      
This reverts commit 4b43537.

Revert "Version bump for kodi dependency (home-assistant#5307)"

This reverts commit 6abad6b.

Revert "Add HMWIOSwitch to sensor, binary (home-assistant#5304)"

This reverts commit 2c3f55a.

Revert "Remove GTFS default name & string change"

This reverts commit 6000c59.

Revert "Update pyhomematic 1.19 & small cleanups (home-assistant#5299)"

This reverts commit a30711f.

Revert "[sensor] Add Dublin bus RTPI sensor (home-assistant#5257)"

This reverts commit 1219ca3.

Revert "Bugfix group reload (home-assistant#5292)"

This reverts commit baa8e53.

Revert "Support for TrackR device trackers (home-assistant#5010)"

This reverts commit f7a1d63.

Revert "Bump pywemo version."

This reverts commit dc937cc.

Revert "Upgrade to voluptuous to 0.9.3 (home-assistant#5288)"

This reverts commit d12decc.

Revert "Upgrade distro to 1.0.2 (home-assistant#5291)"

This reverts commit 64800fd.

Revert "Don't build Adafruit_BBIO - doesn't work on all platforms. (home-assistant#5281)"

This reverts commit 9a3c0c8.

Revert "Convert flic to synchronous platform. (home-assistant#5276)"

This reverts commit eb9b95c.

Revert "Upgrade to aiohttp 1.2 (home-assistant#4964)"

This reverts commit e68e29e.

Revert "Fix TCP sensor to correctly use value_template (home-assistant#5211)"

This reverts commit 1cf9ae5.

Revert "Cleanup language support on TTS (home-assistant#5255)"

This reverts commit 3f3a3bc.

Revert "Add last triggered to script (home-assistant#5261)"

This reverts commit 467cb18.

Revert "Bump flux_led version and make use of PyPi package (home-assistant#5267)"

This reverts commit 34a9fb0.

Revert "Add support for NAD receivers (home-assistant#5191)"

This reverts commit 3b59e16.

Revert "Bugfix async device_tracker see callback (home-assistant#5259)"

This reverts commit 71fddd2.

Revert "Use SHA hash to make token harder to guess (home-assistant#5258)"

This reverts commit 922308b.

    




    

  




  


  
    
  
  

    
  balloob 

      pushed a commit
      that referenced
      this pull request

    
      Jan 27, 2017
    
    

      


  

    

      


  

      
        @nordlead2005
      
        @balloob
  





      

        
          Added forecast support to DarkSky (#5264)
        

          
            
          

          
            
          
      


      

          

    
    
    

  

      


      

      


      
      

        
          8379941
        
      

    

  

    

      
* Added forecast support to DarkSky

	modified:   homeassistant/components/sensor/darksky.py
	modified:   tests/components/sensor/test_darksky.py

* Fix async_volume_up / async_volume_down (#5249)

async_volume_up / async_volume_down should be async versions of
volume_up / volume_down, not a async version of the default variants of
volume_up / volume_down.

The previous code always called into the mediaplayers set_volume_level,
and never into volume_up / volume_down.

Signed-off-by: Anton Lundin <glance@acc.umu.se>

* adding a default icon "blind" to a PowerView blinds scene. (#5210)

* adding a default icon "blind" to a PowerView blinds scene.

* Adding icon property to define blind icon. Removed it from the state attributes dict.

* fixing lint error

* Added forecast support to DarkSky

	modified:   homeassistant/components/sensor/darksky.py
	modified:   tests/components/sensor/test_darksky.py

* Use SHA hash to make token harder to guess (#5258)

* Use SHA hash to make token harder to guess

Use hashlib SHA256 to encode object id instead of using it directly.

* Cache access token

Instead of generating a token on the fly cache it in the constructor.

* Fix lint

* Bugfix async device_tracker see callback (#5259)

* Add support for NAD receivers (#5191)

* Add support for NAD receivers

* remove self.update() in various methods

* remove setting attributes in various methods

* Change import to hass style

* Updated Config Validation, extended daily forecast to all supported types

* Fix style errors from previous commit, fix test since adding daily for all supported types

* Removed temperature from daily as it isn't supported

* Added forecast support to DarkSky

	modified:   homeassistant/components/sensor/darksky.py
	modified:   tests/components/sensor/test_darksky.py

* Updated Config Validation, extended daily forecast to all supported types

* Fix style errors from previous commit, fix test since adding daily for all supported types

* Removed temperature from daily as it isn't supported

* Revert "Bugfix camera streams (#5306)"

This reverts commit 4b43537.

Revert "Version bump for kodi dependency (#5307)"

This reverts commit 6abad6b.

Revert "Add HMWIOSwitch to sensor, binary (#5304)"

This reverts commit 2c3f55a.

Revert "Remove GTFS default name & string change"

This reverts commit 6000c59.

Revert "Update pyhomematic 1.19 & small cleanups (#5299)"

This reverts commit a30711f.

Revert "[sensor] Add Dublin bus RTPI sensor (#5257)"

This reverts commit 1219ca3.

Revert "Bugfix group reload (#5292)"

This reverts commit baa8e53.

Revert "Support for TrackR device trackers (#5010)"

This reverts commit f7a1d63.

Revert "Bump pywemo version."

This reverts commit dc937cc.

Revert "Upgrade to voluptuous to 0.9.3 (#5288)"

This reverts commit d12decc.

Revert "Upgrade distro to 1.0.2 (#5291)"

This reverts commit 64800fd.

Revert "Don't build Adafruit_BBIO - doesn't work on all platforms. (#5281)"

This reverts commit 9a3c0c8.

Revert "Convert flic to synchronous platform. (#5276)"

This reverts commit eb9b95c.

Revert "Upgrade to aiohttp 1.2 (#4964)"

This reverts commit e68e29e.

Revert "Fix TCP sensor to correctly use value_template (#5211)"

This reverts commit 1cf9ae5.

Revert "Cleanup language support on TTS (#5255)"

This reverts commit 3f3a3bc.

Revert "Add last triggered to script (#5261)"

This reverts commit 467cb18.

Revert "Bump flux_led version and make use of PyPi package (#5267)"

This reverts commit 34a9fb0.

Revert "Add support for NAD receivers (#5191)"

This reverts commit 3b59e16.

Revert "Bugfix async device_tracker see callback (#5259)"

This reverts commit 71fddd2.

Revert "Use SHA hash to make token harder to guess (#5258)"

This reverts commit 922308b.

* Revert "Revert "Bugfix camera streams (#5306)""

This reverts commit 2ee8c44.

* Update darksky.py

    




    

  




  

  

    
  

  


    

        @home-assistant
home-assistant




      locked and limited conversation to collaborators


    Apr 30, 2017

  














  
  

    

      

  




    


    

      

             

  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.


  


      

    

  




  
          




      

  

    

    
  

    Reviewers
  


    


        

          

  
    @MatoKafkac
  
    MatoKafkac



          
            
              
            
          
          MatoKafkac left review comments

        


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    component

  

    requirement









      

  

    

        

    Projects
  


        




    None yet




  



      

  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.


  
    
None yet

  




    
  




        
      

    

  
      

  

    

      5 participants
    

    

        
          @pavoni 
        
          @mention-bot 
        
          @balloob 
        
          @MatoKafkac 
        
          @balloobbot