Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arcam lib to 0.7.0 #52829

Merged
merged 1 commit into from Jul 10, 2021
Merged

Update arcam lib to 0.7.0 #52829

merged 1 commit into from Jul 10, 2021

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jul 10, 2021

Proposed change

Upgrade arcam fmj to 0.7.0 that support python 3.9. Changes are mostly typing related, and dropping of asynctest as well as support for python 3.9

elupus/arcam_fmj@0.5.3...0.7.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@elupus elupus added this to the 2021.7.2 milestone Jul 10, 2021
@project-bot project-bot bot added this to Needs review in Dev Jul 10, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 10, 2021
Dev automation moved this from By Code Owner to Reviewer approved Jul 10, 2021
@elupus elupus merged commit dd648f5 into home-assistant:dev Jul 10, 2021
Dev automation moved this from Reviewer approved to Done Jul 10, 2021
@elupus elupus deleted the arcam_0_7_0 branch July 10, 2021 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thecode thecode thecode approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency dependency-bump integration: arcam_fmj small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
2021.7.2
Development

Successfully merging this pull request may close these issues.

No more Arcam AVR control after core update
4 participants
@elupus @thecode @balloob @homeassistant