Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

More restrictive state updates of UniFi uptime sensor #53111

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jul 17, 2021

Breaking change

Proposed change

Remove state changes that are not related to the device having a new uptime.
Epoch time (old way of reporting uptime by UniFi) only needs to trigger state change when it has increased.
Uptime in seconds should only trigger state change when smaller than what previously has been reported.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jul 17, 2021
@Kane610 Kane610 added this to the 2021.7.4 milestone Jul 17, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 17, 2021
Dev automation moved this from By Code Owner to Reviewer approved Jul 19, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 馃憤

@frenck frenck merged commit d121105 into home-assistant:dev Jul 19, 2021
Dev automation moved this from Reviewer approved to Done Jul 19, 2021
@Kane610 Kane610 deleted the unifi-improve_stability_of_uptime_sensor branch July 19, 2021 09:17
@Kane610
Copy link
Member Author

Kane610 commented Jul 19, 2021

Thanks @frenck 馃帀

@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

UniFi uptime sensor is changing a few milli (or micro) seconds now and then
5 participants