Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce strict typing for OpenUV #53409

Merged
merged 3 commits into from Jul 24, 2021
Merged

Enforce strict typing for OpenUV #53409

merged 3 commits into from Jul 24, 2021

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jul 23, 2021

Proposed change

This PR enforces strict mypy typing for OpenUV.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been adde

@bachya bachya self-assigned this Jul 23, 2021
@project-bot project-bot bot added this to Needs review in Dev Jul 23, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 23, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 24, 2021
Dev automation moved this from By Code Owner to Reviewer approved Jul 24, 2021
frenck
frenck approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @bachya 👍

@frenck frenck merged commit 54ace4c into home-assistant:dev Jul 24, 2021
Dev automation moved this from Reviewer approved to Done Jul 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2021
@bachya bachya deleted the openuv-strict-typing branch July 27, 2021 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees

@bachya bachya

Labels
by-code-owner cla-signed code-quality integration: openuv smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachya @frenck @homeassistant