Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase pool max size for urllib3 in Fritz integration #53461

Merged
merged 1 commit into from Jul 26, 2021

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Jul 25, 2021

Proposed change

To avoid exhausting pool, default of 10 should be increased.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @mammuth, @AaronDavidSchneider, mind taking a look at this pull request as its been labeled with an integration (fritz) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jul 25, 2021
Dev automation moved this from By Code Owner to Reviewer approved Jul 25, 2021
@AaronDavidSchneider
Copy link
Contributor

AaronDavidSchneider commented Jul 26, 2021

30 seems to be fine. I tested with 20 activated switches and had no problem. This seems reasonable (IMO).
However, it seems that we are creating a lot of delay which causes updates to take long times.

2021-07-26 07:32:26 WARNING (MainThread) [homeassistant.helpers.entity] Update of switch.fritz_box_7530_wi_fi_rosefy is taking over 10 seconds
2021-07-26 07:32:26 WARNING (MainThread) [homeassistant.helpers.entity] Update of switch.fritz_box_7530_wi_fi_rosefy_5ghz is taking over 10 seconds
2021-07-26 07:32:26 WARNING (MainThread) [homeassistant.helpers.entity] Update of switch.fritz_box_7530_wi_fi_rosefy_guests is taking over 10 seconds

Therefore, even though this PR fixes the symptom (the error itself), we may need to think more about how we could reduce api calls.

But this would probably involve reworking fritzconnection such that fritz can be local push instead of local polling...

@chemelli74
Copy link
Contributor Author

However, it seems that we are creating a lot of delay which causes updates to take long times.

2021-07-26 07:32:26 WARNING (MainThread) [homeassistant.helpers.entity] Update of switch.fritz_box_7530_wi_fi_rosefy is taking over 10 seconds
2021-07-26 07:32:26 WARNING (MainThread) [homeassistant.helpers.entity] Update of switch.fritz_box_7530_wi_fi_rosefy_5ghz is taking over 10 seconds
2021-07-26 07:32:26 WARNING (MainThread) [homeassistant.helpers.entity] Update of switch.fritz_box_7530_wi_fi_rosefy_guests is taking over 10 seconds

I never saw those delays on my box, maybe something transient in your network/environment.

Therefore, even though this PR fixes the symptom (the error itself), we may need to think more about how we could reduce api calls.

But this would probably involve reworking fritzconnection such that fritz can be local push instead of local polling...

Not sure Fritz!Box device allows to maintain the connection open for subsequent calls.
Anyway is a huge rework that will involve primarily the author of fritzconnection library.

Simone

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 26, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @chemelli74 馃憤

@frenck frenck merged commit 37d6824 into home-assistant:dev Jul 26, 2021
Dev automation moved this from Reviewer approved to Done Jul 26, 2021
@chemelli74 chemelli74 deleted the chemelli74-pool branch July 26, 2021 14:50
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cla-signed integration: fritz small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Connection pool is full, discarding connection: 192.168.178.1
5 participants