New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase pool max size for urllib3 in Fritz integration #53461
Conversation
Hey there @mammuth, @AaronDavidSchneider, mind taking a look at this pull request as its been labeled with an integration ( |
219e3bb
to
5eb4756
Compare
30 seems to be fine. I tested with 20 activated switches and had no problem. This seems reasonable (IMO).
Therefore, even though this PR fixes the symptom (the error itself), we may need to think more about how we could reduce api calls. But this would probably involve reworking |
I never saw those delays on my box, maybe something transient in your network/environment.
Not sure Fritz!Box device allows to maintain the connection open for subsequent calls. Simone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @chemelli74 馃憤
Proposed change
To avoid exhausting pool, default of 10 should be increased.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: