Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique_id to Uptime Robot config_flow #54055

Merged
merged 3 commits into from Aug 5, 2021
Merged

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 5, 2021

Breaking change

Add unique_id to the Config Flow

To better handle API key issues pyuptimerobot was bumped to 21.8.2
https://github.com/ludeeus/pyuptimerobot/releases/tag/21.8.2

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 5, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 5, 2021
MartinHjelmare
MartinHjelmare previously approved these changes Aug 5, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Aug 5, 2021
@ludeeus ludeeus dismissed MartinHjelmare鈥檚 stale review August 5, 2021 12:08

Thanks for the approval, but I'ts still missing the library bump and adjustments for api_key issues

Dev automation moved this from Reviewer approved to Review in progress Aug 5, 2021
Dev automation moved this from Review in progress to Reviewer approved Aug 5, 2021
@ludeeus ludeeus merged commit 786a83f into dev Aug 5, 2021
Dev automation moved this from Reviewer approved to Done Aug 5, 2021
@ludeeus ludeeus deleted the uptimerobot_uniqueid_configflow branch August 5, 2021 12:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants