Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restores unit_of_measurement #54335

Merged
merged 2 commits into from Aug 9, 2021

Conversation

dgomes
Copy link
Contributor

@dgomes dgomes commented Aug 9, 2021

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Aug 9, 2021
@project-bot project-bot bot added this to Needs review in Dev Aug 9, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 9, 2021
Dev automation moved this from By Code Owner to Review in progress Aug 9, 2021
@frenck frenck removed the almost-done label Aug 9, 2021
@frenck frenck added this to the 2021.8.5 milestone Aug 9, 2021
Dev automation moved this from Review in progress to Reviewer approved Aug 9, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dgomes 馃憤

@frenck frenck merged commit b88f0ad into home-assistant:dev Aug 9, 2021
Dev automation moved this from Reviewer approved to Done Aug 9, 2021
balloob pushed a commit that referenced this pull request Aug 10, 2021
@balloob balloob mentioned this pull request Aug 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Reimann sum missing units
4 participants