Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill cleanup #54396

Merged
merged 2 commits into from Aug 10, 2021
Merged

Mill cleanup #54396

merged 2 commits into from Aug 10, 2021

Conversation

Danielhiversen
Copy link
Member

Signed-off-by: Daniel Hjelseth H酶yer github@dahoiv.net

Breaking change

Proposed change

Fix late comments: #52311

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Signed-off-by: Daniel Hjelseth H酶yer <github@dahoiv.net>
@project-bot project-bot bot added this to Needs review in Dev Aug 10, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 10, 2021
Signed-off-by: Daniel Hjelseth H酶yer <github@dahoiv.net>
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 10, 2021
Dev automation moved this from By Code Owner to Reviewer approved Aug 10, 2021
@ludeeus ludeeus merged commit f03b160 into dev Aug 10, 2021
Dev automation moved this from Reviewer approved to Done Aug 10, 2021
@ludeeus ludeeus deleted the mill branch August 10, 2021 14:28
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed code-quality integration: mill small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants