Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty currency from discovery info #54478

Merged
merged 1 commit into from Aug 11, 2021
Merged

Remove empty currency from discovery info #54478

merged 1 commit into from Aug 11, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Aug 11, 2021

Proposed change

During the implementation of currency into the core settings, I've used internal/external URL as the base for that implementation.

Because of that, currency ended up in the discovery information. This cleans that up.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (api) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Aug 11, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 11, 2021
@frenck frenck mentioned this pull request Aug 11, 2021
21 tasks
Dev automation moved this from Needs review to Reviewer approved Aug 11, 2021
@balloob balloob merged commit 13c34d6 into dev Aug 11, 2021
Dev automation moved this from Reviewer approved to Done Aug 11, 2021
@balloob balloob deleted the frenck-2021-2154 branch August 11, 2021 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed core integration: api small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants