Move temperature conversions to sensor base class (8/8) #54483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emontnemery
requested review from
Adminiuga,
andrey-git,
Danielhiversen,
dmulcahey,
fabaff,
frenck,
hunterjm,
ludeeus,
MartinHjelmare,
pavoni,
rohankapoorcom,
rytilahti,
syssi and
a team
as code owners
rytilahti
reviewed
Aug 11, 2021
| @@ -331,7 +331,7 @@ def available(self): | |||
| return self._available | |||
|
|
|||
| @property | |||
| def state(self): | |||
| def native_value(self): | |||
| """Return the state of the device.""" | |||
There was a problem hiding this comment.
Should the docstrings also be updated accordingly?
balloob
approved these changes
Aug 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Move temperature conversions to sensor base class
SensorEntity(8/8)Temperature conversion will only be done for sensors with device class set to
temperature.Temperature conversion will still be done for other sensor entities during a transition period, which will end with Home Assistant Core 2022.3.0.
Temperature conversion for non sensor entities is unaffected by this PR.
This PR migrates sensors in integrations v-z to be compatible with unit conversion in
SensorEntity.Additional PRs will be opened to migrate sensors from other integrations
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: