Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve switch/verify register type convert problem in modbus #54645

Merged
merged 1 commit into from Aug 16, 2021

Conversation

janiversen
Copy link
Member

Breaking change

Proposed change

allowed is "write_type: coils" and consequently also "verify/input_type: coils", but the conversion was only for write_type.

Changed the conversion to be for both.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @adamchengtkc, @vzahradnik, mind taking a look at this pull request as it has been labeled with an integration (modbus) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 15, 2021
@janiversen janiversen added this to the 2021.8.7 milestone Aug 15, 2021
Dev automation moved this from By Code Owner to Reviewer approved Aug 16, 2021
@balloob balloob merged commit bec42b7 into home-assistant:dev Aug 16, 2021
Dev automation moved this from Reviewer approved to Done Aug 16, 2021
@balloob balloob mentioned this pull request Aug 16, 2021
@janiversen janiversen deleted the call_type_x_coils branch August 16, 2021 07:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Modbus wont verify switch status when write_coil/read_coils is used
3 participants