Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data update coordinator to the Tautulli integration #54706

Merged
merged 5 commits into from Aug 28, 2021

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Aug 16, 2021

Breaking change

Proposed change

Replaces the old style "dataclass" with a DataUpdateCoordinator for the Tautulli integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 16, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 16, 2021
@ludeeus ludeeus added the smash Indicator this PR is close to finish for merging or closing label Aug 17, 2021
homeassistant/components/tautulli/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/tautulli/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/tautulli/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/tautulli/sensor.py Show resolved Hide resolved
ludeeus and others added 2 commits August 26, 2021 08:56
Co-authored-by: Chris Talkington <chris@talkingtontech.com>
Dev automation moved this from By Code Owner to Reviewer approved Aug 28, 2021
@ctalkington ctalkington merged commit 470aa7e into dev Aug 28, 2021
Dev automation moved this from Reviewer approved to Done Aug 28, 2021
@ctalkington ctalkington deleted the tautulli-coordinator branch August 28, 2021 01:39
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed code-quality integration: tautulli smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants