Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HomeKit cover creation with tilt position, open/close, no set position #54727

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 16, 2021

Proposed change

  • The accessory builder/sorter should create these as WindowCoveringBasic
    instead of WindowCovering

Fixes #54684

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

…ition

- The accessory builder/sorter should create these as WindowCoveringBasic
  instead of WindowCovering
@project-bot project-bot bot added this to Needs review in Dev Aug 16, 2021
@bdraco bdraco added this to the 2021.8.8 milestone Aug 16, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 16, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 16, 2021
Dev automation moved this from By Code Owner to Reviewer approved Aug 18, 2021
@bdraco
Copy link
Member Author

bdraco commented Aug 18, 2021

Thanks 👍

@bdraco bdraco merged commit 87496ae into home-assistant:dev Aug 18, 2021
Dev automation moved this from Reviewer approved to Done Aug 18, 2021
@balloob balloob mentioned this pull request Aug 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cherry-picked cla-signed has-tests integration: homekit small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

HomeKit Bridge blind covers no longer open and close
5 participants