implementing users remarks #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* accept hexadecimal format of commands * support for media player * platform customization * type constants
* accept hexadecimal format of commands * support for media player * platform customization * preparing tcp support
* cleanup imports * cleanup and enhance services description * removed unwanted file
* pyCEC v0.4.6 * pined dependency version * tighten service schemas
* home-assistant-29 counting from 0 (#29)
|
@konikvranik, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fabaff, @balloob and @robbiet480 to be potential reviewers. |
balloob
reviewed
Jan 21, 2017
| @@ -95,6 +95,7 @@ | |||
| CONF_FRIENDLY_NAME = 'friendly_name' | |||
| CONF_HEADERS = 'headers' | |||
| CONF_HOST = 'host' | |||
| CONF_DISPLAY_NAME = 'osd_name' | |||
There was a problem hiding this comment.
Please keep this one in your component definition.
|
Top! 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implementing features and fixing bugs reported by users.
Related issue: fixes konikvranik/home-assistant#31, konikvranik/home-assistant#30, konikvranik/home-assistant#29, konikvranik/pyCEC#30
Checklist:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.