Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EntityDescription - notion #55120

Merged
merged 3 commits into from Aug 25, 2021
Merged

Use EntityDescription - notion #55120

merged 3 commits into from Aug 25, 2021

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Aug 23, 2021

Proposed change

Update notion to use EntityDescription for sensor metadata.
-> #53201

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

@bachya bachya self-assigned this Aug 23, 2021
@project-bot project-bot bot added this to Needs review in Dev Aug 23, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 23, 2021
cdce8p
cdce8p reviewed Aug 23, 2021
View reviewed changes
homeassistant/components/notion/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/notion/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/notion/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/notion/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/notion/binary_sensor.py Outdated Show resolved Hide resolved
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 24, 2021
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Aug 24, 2021
@bachya bachya added the smash Indicator this PR is close to finish for merging or closing label Aug 24, 2021
@bachya bachya force-pushed the notion-entity-description branch 2 times, most recently from 6d030ae to 84fc6e3 Compare August 25, 2021 01:37
@frenck
Copy link
Member

frenck commented Aug 25, 2021

Rebased to deal with the CI issues

Dev automation moved this from By Code Owner to Reviewer approved Aug 25, 2021
frenck
frenck approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, @bachya 👍

@frenck frenck merged commit f92ba18 into home-assistant:dev Aug 25, 2021
Dev automation moved this from Reviewer approved to Done Aug 25, 2021
@bachya bachya deleted the notion-entity-description branch August 25, 2021 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2021
@cdce8p cdce8p added the project-code_style PRs related to #53201 - pylint CodeStyle update label Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdce8p cdce8p cdce8p left review comments

@frenck frenck frenck approved these changes

Assignees

@bachya bachya

Labels
by-code-owner cla-signed code-quality integration: notion project-code_style PRs related to #53201 - pylint CodeStyle update smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bachya @frenck @cdce8p @homeassistant