Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rainforest eagle incorrectly fetch conncted first try #55193

Merged
merged 1 commit into from Aug 25, 2021

Conversation

balloob
Copy link
Member

@balloob balloob commented Aug 25, 2021

Breaking change

Proposed change

The first time is_connected is not populated and can raise. This prevents that and only fetches is_connected from the meter if data has been fetched once.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@balloob balloob added the smash Indicator this PR is close to finish for merging or closing label Aug 25, 2021
@probot-home-assistant
Copy link

Hey there @gtdiehl, @jcalbert, mind taking a look at this pull request as it has been labeled with an integration (rainforest_eagle) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck force-pushed the eagle-dont-read-connected-first-try branch from 6d0b5a4 to f62a48b Compare August 25, 2021 07:10
@frenck
Copy link
Member

frenck commented Aug 25, 2021

Rebased the PR to deal with the CI issue

@frenck frenck merged commit 186b8d4 into dev Aug 25, 2021
@frenck frenck deleted the eagle-dont-read-connected-first-try branch August 25, 2021 09:43
@github-actions github-actions bot locked and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed integration: rainforest_eagle small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants