Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address late review for Renault integration #55230

Merged
merged 7 commits into from Aug 27, 2021

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Aug 25, 2021

Proposed change

Implement recommendations from #55061

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 25, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 25, 2021
@epenet epenet changed the title Add type hints to renault integration tests Tidy renault integration Aug 26, 2021
@epenet
Copy link
Contributor Author

epenet commented Aug 26, 2021

cc @MartinHjelmare as author of initial review

@epenet epenet changed the title Tidy renault integration Tidy-up renault integration Aug 26, 2021
tests/components/renault/const.py Outdated Show resolved Hide resolved
tests/components/renault/__init__.py Outdated Show resolved Hide resolved
@epenet epenet changed the title Tidy-up renault integration Address late review for Renault integration Aug 26, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from By Code Owner to Reviewer approved Aug 27, 2021
@MartinHjelmare MartinHjelmare merged commit 9ba504c into home-assistant:dev Aug 27, 2021
Dev automation moved this from Reviewer approved to Done Aug 27, 2021
@epenet epenet deleted the renault-testing branch August 27, 2021 05:50
@epenet
Copy link
Contributor Author

epenet commented Aug 27, 2021

Thanks @MartinHjelmare

@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants