Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color mode support to zengge light #55260

Merged
merged 1 commit into from Apr 1, 2022

Conversation

emontnemery
Copy link
Contributor

@emontnemery emontnemery commented Aug 26, 2021

Breaking change

zengge lights no longer support white_value, use white instead.

Proposed change

Add color_ mode support to zengge light
Flag support for hs and white color modes

Note:
The driver for this PR is that white_value is deprecated, with a plan for complete removal in 2021.10.

I have no way to test the changes myself, so I'm marking this PR as draft for now

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 26, 2021
@emontnemery
Copy link
Contributor Author

@N1nja98 , @rohankapoorcom Can you give the change a try, I have no way to test it myself

@emontnemery emontnemery marked this pull request as draft August 26, 2021 10:55
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 25, 2021
@github-actions github-actions bot closed this Oct 2, 2021
Dev automation moved this from Needs review to Cancelled Oct 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2021
@emontnemery emontnemery reopened this Apr 1, 2022
@emontnemery emontnemery added no-stale and removed stale labels Apr 1, 2022
@emontnemery emontnemery marked this pull request as ready for review April 1, 2022 11:59
@emontnemery
Copy link
Contributor Author

emontnemery commented Apr 1, 2022

I'm merging this since there's not been any feedback in 6 months and this is blocking removal of deprecated features from light

@frenck frenck merged commit 044d71f into home-assistant:dev Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

3 participants