Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

xiaomi_miio: bump python-miio dependency #55549

Merged
merged 1 commit into from Sep 1, 2021

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Sep 1, 2021

Breaking change

Proposed change

Bumps python-miio dependency to the new upstream version. Changelog: https://github.com/rytilahti/python-miio/releases/tag/0.5.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Sep 1, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Sep 1, 2021
@rytilahti rytilahti marked this pull request as ready for review September 1, 2021 21:41
Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

Dev automation moved this from By Code Owner to Reviewer approved Sep 1, 2021
@bieniu bieniu modified the milestone: 2021.9.0 Sep 1, 2021
@rytilahti
Copy link
Member Author

The milestone should be 2021.9.1, right?

@rytilahti rytilahti merged commit aef4a69 into home-assistant:dev Sep 1, 2021
Dev automation moved this from Reviewer approved to Done Sep 1, 2021
@rytilahti rytilahti deleted the xiaomi_miio/bump_058 branch September 1, 2021 22:18
@bieniu
Copy link
Member

bieniu commented Sep 1, 2021

Yes

@MartinHjelmare
Copy link
Member

Please add a link to a changelog or GitHub commit compare view for the version bump in the PR description. Thanks!

@rytilahti
Copy link
Member Author

Good catch @MartinHjelmare! I left a placeholder and forgot to update it, but it's now there.

@bieniu bieniu added this to the 2021.9.1 milestone Sep 2, 2021
@balloob balloob mentioned this pull request Sep 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Miio Humidifier 'depth' warning - 100+ times per 30min
6 participants