Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NamedTuple in service_to_method mapping #55756

Closed
wants to merge 1 commit into from

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 4, 2021

Proposed change

Use NamedTuple instead of dict to map a service to a method and schema.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @andre-richter, mind taking a look at this pull request as it has been labeled with an integration (vallox) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @bendavid, @thecode, mind taking a look at this pull request as it has been labeled with an integration (webostv) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Sep 4, 2021
@cdce8p cdce8p added the project-code_style PRs related to #53201 - pylint CodeStyle update label Sep 4, 2021
Copy link
Contributor

@andre-richter andre-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cdce8p
Copy link
Member Author

cdce8p commented Sep 6, 2021

@ludeeus I would be interested in your opinion on this one?
The name and location for ServiceMethodDetails can certainly be improved a bit, but that's what I came up with so far.

Dev automation moved this from Needs review to Reviewer approved Sep 6, 2021
Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM webostv

@cdce8p cdce8p added the second-opinion-wanted Add this label when a reviewer needs a second opinion from another member. label Sep 6, 2021
@cdce8p
Copy link
Member Author

cdce8p commented Sep 29, 2021

Closing it - It doesn't make much sense to add a generic NamedTuple just for these few integrations.

@cdce8p cdce8p closed this Sep 29, 2021
Dev automation moved this from Reviewer approved to Cancelled Sep 29, 2021
@cdce8p cdce8p deleted the nt_service-to-method branch September 29, 2021 00:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality core integration: bluesound integration: vallox integration: webostv integration: xiaomi_miio project-code_style PRs related to #53201 - pylint CodeStyle update second-opinion-wanted Add this label when a reviewer needs a second opinion from another member.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

7 participants