Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting TRV "_TZE200_b6wax7g0" #55782

Closed
wants to merge 1 commit into from
Closed

Deleting TRV "_TZE200_b6wax7g0" #55782

wants to merge 1 commit into from

Conversation

MattWestb
Copy link
Contributor

The device is not compatible with the current quirk after some feedback from users and then looking on Z2M.
PR is made deleting it in Zigpy and also need doing the same in ZHA
zigpy/zha-device-handlers#1023

This partly reversing the #52065

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

The device is not compatible with the current quirk after some feedback from users and then looking on Z2M.
PR is made deleting it in Zigpy and also need doing the same in ZHA
zigpy/zha-device-handlers#1023
@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Sep 5, 2021
@MattWestb
Copy link
Contributor Author

MattWestb commented Sep 5, 2021

For clarifying if the TRV type "_TZE200_b6wax7g0" is deleted in Zigbpy then this PR shall being merged and if its not being deleted this shall being deleted for not braking the support for the devices.

@MattWestb
Copy link
Contributor Author

Its looks some users is using the quirk for there devices and need this for getting it working.
I have flagged it as draft and is releasing it then Zigpy devs have desired to delet or keeping the device in the quirk.
Also one user have making more patches for getting ti working but have not (yet) making one PR for adding it to the dev branch but it can being made and its flagged as not all function is working OK in the tuya TRV matrix zigpy/zigpy#653 (comment).

@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Oct 4, 2021
@MattWestb
Copy link
Contributor Author

Still not cleared if the device staying as it is or the devs is helping the user fixing only one issue with the device.
Still for the moment its better having it left then removing it and all user have device that is not working at all.

@MattWestb
Copy link
Contributor Author

The ZHA_Quirk is being updated with one fix for the MOES_TARGET_TEMP_ATTR: multiplier is corrected zigpy/zha-device-handlers#1082 so the device is staying in ZHA so i closing this PR.

@MattWestb MattWestb closed this Oct 18, 2021
Dev automation moved this from Incoming to Cancelled Oct 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2021
@MattWestb MattWestb deleted the patch-1 branch November 7, 2021 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

4 participants