Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EntityDescription - aqualogic #55791

Merged
merged 3 commits into from Sep 6, 2021
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 5, 2021

Proposed change

Update aqualogic to use EntityDescription for sensor metadata.
-> #53201

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Sep 5, 2021
@cdce8p cdce8p added project-code_style PRs related to #53201 - pylint CodeStyle update smash Indicator this PR is close to finish for merging or closing labels Sep 5, 2021
Dev automation moved this from Needs review to Reviewer approved Sep 6, 2021
@ludeeus ludeeus merged commit 4475cf2 into home-assistant:dev Sep 6, 2021
Dev automation moved this from Reviewer approved to Done Sep 6, 2021
@cdce8p cdce8p deleted the cs_12_aqualogic branch September 6, 2021 09:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality integration: aqualogic project-code_style PRs related to #53201 - pylint CodeStyle update smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants