New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ZHA tests #55844
Refactor ZHA tests #55844
Conversation
Use the same dict key names for device signature mocks as zha quirks.
Hey there @dmulcahey, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just flake8 issue and then good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I fix it from the mobile
Breaking change
No
Proposed change
Refactor ZHA tests and stop using "FakeDevice" and "FakeEndpoint" for zigpy devices and instead use patched instances of
zigpy.device.Device
andzigpy.endpoint.Endpoint
.Replace keys in
zha_device_list.py
with consts from zha-quirks signature, to make the device signature more consistent.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: