New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed wording of bond state belief feature from belief to tracked state #56147
Merged
bdraco
merged 26 commits into
home-assistant:dev
from
joshs85:add-bond-state-belief-feature
Sep 13, 2021
Merged
Changed wording of bond state belief feature from belief to tracked state #56147
bdraco
merged 26 commits into
home-assistant:dev
from
joshs85:add-bond-state-belief-feature
Sep 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: J. Nick Koston <nick@koston.org>
… and made parameters required
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: J. Nick Koston <nick@koston.org>
… and re raise them as HomeAssistantErrors.
… if statement and un indented the remaining code for the function removing from else
probot-home-assistant
bot
added
dependency
has-tests
integration: bond
new-feature
labels
Sep 12, 2021
Hey there @prystupa, mind taking a look at this pull request as it has been labeled with an integration ( |
21 tasks
joshs85
changed the title
Add bond state belief feature
Changed wording of bond state belief feature from belief to tracked state
Sep 12, 2021
bdraco
approved these changes
Sep 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
…shs85/core into add-bond-state-belief-feature
bdraco
approved these changes
Sep 12, 2021
bdraco
reviewed
Sep 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Changed the naming of the bond services from belief to tracked state
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: