-
-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renson integration #56374
Renson integration #56374
Conversation
Hi @jimmyd-be, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant/components/renson_endura_delta/test_config_flow.py
Outdated
Show resolved
Hide resolved
@balloob is the code better now? So I can starting migrating my service to entity services. |
What's the status of this PR and when will it get merged? |
You can already use the integration when installing using HACS. https://github.com/jimmyd-be/Home-Assistant-Sensor-Renson-Ventilation The HACS version contains already a lot more features then this PR. But when this is merged I'm going to work asap to migrate all the features to the official integration |
I've marked this PR as draft, as changes are requested that need to be processed first or more discussion is needed. Thanks! 👍 |
Please add the files that are not covered by tests to |
Added the files to .coveragerc. Github PR is not yet seeing my latest commits. Try to find out why before I click 'ready for review' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment remains:
#56374 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! Thanks for your patience!
Breaking change
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: