Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renson integration #56374

Merged
merged 53 commits into from
Jun 10, 2023
Merged

Conversation

jimmyd-be
Copy link
Contributor

@jimmyd-be jimmyd-be commented Sep 18, 2021

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hi @jimmyd-be,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@jimmyd-be
Copy link
Contributor Author

@balloob is the code better now? So I can starting migrating my service to entity services.

@jimmyd-be jimmyd-be marked this pull request as ready for review March 31, 2023 13:31
@ThomasVerhoeven1998
Copy link

What's the status of this PR and when will it get merged?

@jimmyd-be
Copy link
Contributor Author

What's the status of this PR and when will it get merged?

You can already use the integration when installing using HACS. https://github.com/jimmyd-be/Home-Assistant-Sensor-Renson-Ventilation

The HACS version contains already a lot more features then this PR. But when this is merged I'm going to work asap to migrate all the features to the official integration

@marcelveldt marcelveldt marked this pull request as draft June 7, 2023 10:47
@marcelveldt
Copy link
Member

I've marked this PR as draft, as changes are requested that need to be processed first or more discussion is needed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

Learn more about our pull request process.

@MartinHjelmare
Copy link
Member

Please add the files that are not covered by tests to .coveragerc.

@jimmyd-be
Copy link
Contributor Author

Please add the files that are not covered by tests to .coveragerc.

Added the files to .coveragerc. Github PR is not yet seeing my latest commits. Try to find out why before I click 'ready for review'

@jimmyd-be jimmyd-be marked this pull request as ready for review June 7, 2023 18:26
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment remains:
#56374 (comment)

@home-assistant home-assistant bot marked this pull request as draft June 8, 2023 10:23
@jimmyd-be jimmyd-be marked this pull request as ready for review June 8, 2023 10:42
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks for your patience!

@MartinHjelmare MartinHjelmare merged commit 3d678f5 into home-assistant:dev Jun 10, 2023
50 of 51 checks passed
Dev automation moved this from Review in progress to Done Jun 10, 2023
@jimmyd-be jimmyd-be deleted the renson-integration branch June 10, 2023 07:52
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet