Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strictly type tradfri cover.py #56390

Merged
merged 6 commits into from Sep 21, 2021

Conversation

janiversen
Copy link
Member

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

tested locally by activating mypy strict (using already converted base_class.py)

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Sep 18, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Sep 18, 2021
@janiversen janiversen force-pushed the strict_tradfri_cover branch 2 times, most recently from 79a8546 to 765726c Compare September 20, 2021 12:59
homeassistant/components/tradfri/cover.py Outdated Show resolved Hide resolved
homeassistant/components/tradfri/cover.py Outdated Show resolved Hide resolved
homeassistant/components/tradfri/cover.py Outdated Show resolved Hide resolved
homeassistant/components/tradfri/cover.py Outdated Show resolved Hide resolved
homeassistant/components/tradfri/cover.py Show resolved Hide resolved
Dev automation moved this from By Code Owner to Reviewer approved Sep 21, 2021
janiversen and others added 4 commits September 21, 2021 12:29
Co-authored-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
Co-authored-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
Co-authored-by: Ruslan Sayfutdinov <ruslan@sayfutdinov.com>
@janiversen
Copy link
Member Author

Thanks for the push you beat me by a couple of seconds 馃榿 I was just starting to commit etc.

@KapJI
Copy link
Member

KapJI commented Sep 21, 2021

Yeah, I thought you missed that one 馃檪

@KapJI KapJI merged commit 518c99c into home-assistant:dev Sep 21, 2021
Dev automation moved this from Reviewer approved to Done Sep 21, 2021
@janiversen janiversen deleted the strict_tradfri_cover branch September 21, 2021 11:23
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants