Minor refactoring of periodic statistics #56492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Sep 21, 2021
| # Set meta data | ||
| result[entity_id]["meta"] = { | ||
| meta: StatisticMetaData = { | ||
| "statistic_id": entity_id, |
There was a problem hiding this comment.
Are we going to allow integrations to define their own statistic IDs when importing? I guess we can, but we should enforce it starts with <domain>-
balloob
reviewed
Sep 21, 2021
| "unit_of_measurement": unit, | ||
| "has_mean": "mean" in wanted_statistics[entity_id], | ||
| "has_sum": "sum" in wanted_statistics[entity_id], | ||
| } | ||
|
|
||
| # Make calculations | ||
| stat: dict = {} | ||
| stat: StatisticData = {"start": start} |
There was a problem hiding this comment.
This is what's not so cool about TypedDict: handling of optional fields.
balloob
reviewed
Sep 21, 2021
| """Statistic data class.""" | ||
|
|
||
| meta: StatisticMetaData | ||
| stat: tuple[StatisticData, ...] |
There was a problem hiding this comment.
It should be an Iterable, not a tuple.
The purpose is to allow inserting multiple datapoints for unchanged metadata, for example a day's or month's worth of hourly updates and not have to lookup the metadata already stored in the database for each point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Minor refactoring of periodic statistics to prepare for import of statistics
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: