Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yeelight state when controlled outside of Home Assistant #56964

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 2, 2021

Proposed change

  • Devices with bg_power would sometimes send back the wrong state
    after turning on/off power. We now always force an update
    when we get bg_power in an update. This replaces the
    check after turn on/turn off as its more robust as we
    only poll AFTER we get the push update to make sure its
    not too soon.

  • If the nightlight is enabled, we always use nl_br for the
    brightness prop.

  • Report color temp when nightlight mode is enabled as
    max_mireds since nightlight mode locks color temp but
    sends no update since the native yeelight app knows this.

Fixes #56471 Fixes #56749

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- Devices with bg_power would sometimes send back the wrong state
  after turning on/off power. We now always force an update
  when we get bg_power in an update

- If the nightlight is enabled, we always use nl_br for the
  brightness prop
@probot-home-assistant
Copy link

Hey there @rytilahti, @zewelor, @shenxn, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (yeelight) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco added this to the 2021.10.0 milestone Oct 2, 2021
@bdraco bdraco marked this pull request as draft October 2, 2021 23:00
@bdraco
Copy link
Member Author

bdraco commented Oct 2, 2021

testing those two lines is critical but out of time so will have to come back to this.

@bdraco bdraco marked this pull request as ready for review October 3, 2021 00:36
Dev automation moved this from Needs review to Reviewer approved Oct 3, 2021
@balloob balloob merged commit 1aeab65 into home-assistant:dev Oct 3, 2021
Dev automation moved this from Reviewer approved to Done Oct 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants