New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix yeelight state when controlled outside of Home Assistant #56964
Merged
balloob
merged 8 commits into
home-assistant:dev
from
bdraco:yeelight_fix_nightlight_brightness_state
Oct 3, 2021
Merged
Fix yeelight state when controlled outside of Home Assistant #56964
balloob
merged 8 commits into
home-assistant:dev
from
bdraco:yeelight_fix_nightlight_brightness_state
Oct 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Devices with bg_power would sometimes send back the wrong state after turning on/off power. We now always force an update when we get bg_power in an update - If the nightlight is enabled, we always use nl_br for the brightness prop
probot-home-assistant
bot
added
Hacktoberfest
has-tests
integration: yeelight
small-pr
PRs with less than 30 lines.
labels
Oct 2, 2021
Hey there @rytilahti, @zewelor, @shenxn, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( |
This was referenced Oct 2, 2021
testing those two lines is critical but out of time so will have to come back to this. |
balloob
approved these changes
Oct 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cherry-picked
cla-signed
Hacktoberfest
has-tests
integration: yeelight
small-pr
PRs with less than 30 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Devices with bg_power would sometimes send back the wrong state
after turning on/off power. We now always force an update
when we get bg_power in an update. This replaces the
check after turn on/turn off as its more robust as we
only poll AFTER we get the push update to make sure its
not too soon.
If the nightlight is enabled, we always use nl_br for the
brightness prop.
Report color temp when nightlight mode is enabled as
max_mireds since nightlight mode locks color temp but
sends no update since the native yeelight app knows this.
Fixes #56471 Fixes #56749
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: