Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pynws to 1.3.2 #57361

Merged
merged 1 commit into from Oct 9, 2021
Merged

Conversation

MatthewFlamm
Copy link
Contributor

Proposed change

pynws is updated to use newest observations. NWS servers have unexpectedly started providing unsorted obaervations, whereas previously they were sorted by time.

Changes:
MatthewFlamm/pynws@v1.3.1...v1.3.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@MatthewFlamm MatthewFlamm changed the title Bump pynws: fix using old observations Bump pynws: fix using old observations in nws Oct 9, 2021
@MatthewFlamm
Copy link
Contributor Author

This would be good to get into 2021.10.x if possible

@MartinHjelmare MartinHjelmare changed the title Bump pynws: fix using old observations in nws Bump pynws to 1.3.2 Oct 9, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2021.10.3 milestone Oct 9, 2021
@MartinHjelmare MartinHjelmare merged commit 5829f93 into home-assistant:dev Oct 9, 2021
@MatthewFlamm MatthewFlamm deleted the bump-pynws-1.3.2 branch October 9, 2021 21:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NWS Integration Current Condition API change
4 participants