Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove long-term statistics from IQVIA forecast sensor #57687

Merged
merged 1 commit into from Oct 14, 2021

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Oct 14, 2021

Breaking change

Previously, IQVIA supported long-term statistics for the Asthma Index: Tomorrow sensor. This is incorrect: long-term statistics are meant for actual, current measurements (not future forecasts). Therefore, long-term statistics support has been removed for this sensor.

Proposed change

Previously, IQVIA supported long-term statistics for the Asthma Index: Tomorrow sensor. This is incorrect: long-term statistics are meant for actual, current measurements (not future forecasts). Therefore, long-term statistics support has been removed for this sensor.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Oct 14, 2021
@project-bot project-bot bot added this to Needs review in Dev Oct 14, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 14, 2021
Dev automation moved this from By Code Owner to Reviewer approved Oct 14, 2021
@frenck
Copy link
Member

frenck commented Oct 14, 2021

Thanks, @bachya 👍

@frenck frenck merged commit 4745e58 into home-assistant:dev Oct 14, 2021
Dev automation moved this from Reviewer approved to Done Oct 14, 2021
@bachya bachya deleted the iqvia-lts-fix branch October 14, 2021 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants