Add IntesisBox + IntesisHome local support

[jnimmo]

Breaking change

Proposed change

Adds support for IntesisBox devices and local control of some IntesisHome devices.
Adds foundations for config flow, to follow in future PR.

Bump version of pyIntesisHome to 1.8.1 - PR jnimmo/pyIntesisHome@89f0f7e

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Intesis Home connection gets lost and is never restored #58099
• This PR is related to issue:
• Link to documentation pull request: Add IntesisBox + IntesisHome local support home-assistant.io#19825

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[rklomp]

Thanks for the merge request @jnimmo! I have tested this with my intesishome device via the new local polling option and it works 👍🏼

[jnimmo]

Great to hear, thanks for that. I've also got Config Flow working nicely, awaiting writing some tests for it as config flow needs to have 100% coverage - so I'll be looking at the tests you added for pyintesishome to point me in the right direction, thank you.

[AAlmarwani93]

Hello @jnimmo is this currently working on the newest version of home assistant or not as I am trying to add the integration yet it is not working not sure why though.

[prjcarr]

Is there any ETA on when this will be merged into core? Really looking forward to the local polling option.

[jnimmo]

Hello @jnimmo is this currently working on the newest version of home assistant or not as I am trying to add the integration yet it is not working not sure why though.

Hasn't been integrated yet - awaiting a code review

[bdraco]

We no longer accept changes to YAML configuration. Configuration YAML in platform sections in existing integrations is frozen until the integration is refactored to use a config flow.

https://github.com/home-assistant/architecture/blob/master/adr/0007-integration-config-yaml-structure.md

This integration needs to be converted to use a config flow first.

You can get started with the helper script
python3 -m script.scaffold config_flow

https://developers.home-assistant.io/docs/config_entries_config_flow_handler#defining-your-config-flow

Thanks 👍

[jnimmo]

We no longer accept changes to YAML configuration. Configuration YAML in platform sections in existing integrations is frozen until the integration is refactored to use a config flow.

https://github.com/home-assistant/architecture/blob/master/adr/0007-integration-config-yaml-structure.md

This integration needs to be converted to use a config flow first.

You can get started with the helper script

python3 -m script.scaffold config_flow

https://developers.home-assistant.io/docs/config_entries_config_flow_handler#defining-your-config-flow

Thanks 👍

Thanks for the update. After spending many hours on getting this PR ready it is disappointing to not have had a heads up on the change of this requirement.

I have config flow support already in the https://github.com/jnimmo/home-assistant/tree/intesishome-config-flow branch however won't have time in the near future to write the required unit tests for config flow support.

If anyone is able to assist with writing some config flow unit tests please let me know, unsure on how much of the functionality is required to be tested.

This PR and dependency upgrade is also required for bug fixes and stability improvements.

[bdraco]

We can accept a dependency update as long as it doesn't require changing the yaml schema 👍

[evaliukonis]

@jnimmo maybe you can create HACS repo and we can use as hass plugin? I also waiting internal API support.

[peledzius]

There is a bug displaying outdoor_temp attribute when value is exactly 0 that I mentioned in #60259.

I replaced my default integration with this PR, but this bug exists here too.

core/homeassistant/components/intesishome/climate.py

Line 275 in ca35a78

if self._outdoor_temp:

Updating above line to if self._outdoor_temp is not None: fixes the issue.

@jnimmo Please update this PR before it's merged and thank you for your hard work with this PR.

[evaliukonis]

PR exist for wrong negative outdoor temp issue https://github.com/jnimmo/pyIntesisHome/pull/39

[peledzius]

I noticed after I reboot my router with WiFI, it does not update outdoor temperature anymore. Logs showed nothing(with debug enabled). Though I can still power on/off my unit.

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[nerijus]

Please don't close it.

[marcelveldt]

I've marked this PR as draft, as changes are requested that need to be processed first or more discussion is needed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

Learn more about our pull request process.

[github-actions]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[nerijus]

@jnimmo , I'd suggest updating this PR with config flow support, maybe someone will help with unit tests?

[jnimmo]

That's a great idea - let me see what I can do this weekend.

[frenck]

Because there hasn't been any activity on this PR for quite some time now, I've decided to close it for being stale.

Feel free to re-open this PR when you are ready to pick up work on it again 👍

../Frenck