Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nello removal #57926

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Nello removal #57926

merged 1 commit into from
Oct 22, 2021

Conversation

pattyland
Copy link
Contributor

@pattyland pattyland commented Oct 17, 2021

Breaking change

Removes Nello integration.

Proposed change

After Locumi Labs GmbH, the manufacturer of Nello, went bankrupt in 2019, SCLAK continued to operate the servers until June 2021. According to unofficial sources, SCLAK also went bankrupt at the beginning of 2021 and was sold.
For half a year now, the MQTT server with which the door opener connects is not accessible, the homepage (https://www.nello.io/) is down and also the API (https://public-api.nello.io/v1/) has long delivered only 500 errors.
I think it's time to dispose of the integration and the hardware. :(

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @pschmitt, mind taking a look at this pull request as it has been labeled with an integration (nello) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 18, 2021
@frenck
Copy link
Member

frenck commented Oct 22, 2021

Rebased the PR to deal with the CI issues (hopefully).

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pattyland 馃憤

Dev automation moved this from Needs review to Reviewer approved Oct 22, 2021
@frenck frenck merged commit b0b49c6 into home-assistant:dev Oct 22, 2021
Dev automation moved this from Reviewer approved to Done Oct 22, 2021
@pattyland pattyland deleted the nello-removal branch October 22, 2021 20:14
Chen-IL pushed a commit to Chen-IL/homeassistant-core that referenced this pull request Oct 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change cla-signed Hacktoberfest integration: nello remove-platform small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants