Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registration UI to work for Israel devices #58192

Merged
merged 1 commit into from Oct 22, 2021

Conversation

tomer-w
Copy link
Contributor

@tomer-w tomer-w commented Oct 21, 2021

Without it you have to choose fake country like UK to make things work.

Proposed change

This is fixing a bug in the new Tuya integration which make it fail to add integration if the account is from Israel.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Without it you have to choose fake country like UK to make things work.
@tomer-w tomer-w requested a review from frenck as a code owner October 21, 2021 22:11
@project-bot project-bot bot added this to Needs review in Dev Oct 21, 2021
@probot-home-assistant
Copy link

Hey there @tuya, @zlinoliver, @METISU, @frenck, mind taking a look at this pull request as it has been labeled with an integration (tuya) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 22, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tomer-w 馃憤

Dev automation moved this from Needs review to Reviewer approved Oct 22, 2021
@frenck frenck merged commit 766a693 into home-assistant:dev Oct 22, 2021
Dev automation moved this from Reviewer approved to Done Oct 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
@tomer-w tomer-w deleted the patch-1 branch October 25, 2021 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix cla-signed Hacktoberfest integration: tuya small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants