Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DeviceInfo on components with via_device #58222

Merged
merged 2 commits into from Oct 22, 2021

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Oct 22, 2021

Proposed change

Use DeviceInfo on components with via_device - last batch now that ATTR_VIA_DEVICE has been added to const.py (in #58183)
As discussed in #58183 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bdraco, @ehendrix23, mind taking a look at this pull request as it has been labeled with an integration (myq) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @bdraco, @prystupa, @joshs85, mind taking a look at this pull request as it has been labeled with an integration (bond) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @Jc2k, @bdraco, mind taking a look at this pull request as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @cgarwood, @marcelveldt, @MartinHjelmare, mind taking a look at this pull request as it has been labeled with an integration (ozw) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @fredrike, mind taking a look at this pull request as it has been labeled with an integration (tellduslive) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-home-assistant
Copy link

Hey there @garbled1, mind taking a look at this pull request as it has been labeled with an integration (onewire) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Oct 22, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 22, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 22, 2021
Copy link
Member

@Jc2k Jc2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤 for homekit_controller

Dev automation moved this from By Code Owner to Reviewer approved Oct 22, 2021
@epenet
Copy link
Contributor Author

epenet commented Oct 22, 2021

Is codecov/patch something related to this PR? or is it a quirk of the CI process?

@frenck
Copy link
Member

frenck commented Oct 22, 2021

@epenet its because he is hitting code that is untested and thus counts as a patch that is untested.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @epenet 馃憤

@frenck frenck merged commit 51a10f8 into home-assistant:dev Oct 22, 2021
Dev automation moved this from Reviewer approved to Done Oct 22, 2021
@epenet epenet deleted the device-info-attributes branch October 22, 2021 15:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

8 participants