Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Zeroconf discovery for ZigStar Zigbee coordinator to ZHA #58224

Closed
wants to merge 2 commits into from
Closed

Add Zeroconf discovery for ZigStar Zigbee coordinator to ZHA #58224

wants to merge 2 commits into from

Conversation

Hedda
Copy link
Contributor

@Hedda Hedda commented Oct 22, 2021

Breaking change

No.

Proposed change

[Work-In-Progress] This PR will add Zeroconf discovery for ZigStar LAN Gateway to the ZHA integration.

https://zig-star.com/projects/zigbee-gw-lan/

https://github.com/mercenaruss/zigstar_gateways

https://github.com/xyzroe/ZigStarGW-FW

WIP as @mercenaruss and @xyzroe who makes hardware and firmware still need to test/verify this:

xyzroe/ZigStarGW-FW#3

mercenaruss/zigstar_gateways#2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

…rdinator to ZHA

Update manifest.json to add Zeroconf discovery for ZigStar Zigbee coordinator to ZHA
…rdinator to ZHA

Update manifest.json to add Zeroconf discovery for ZigStar Zigbee coordinator to ZHA
@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Oct 22, 2021
@frenck frenck changed the title [WIP] Add Zeroconf discovery for ZigStar Zigbee coordinator to ZHA Add Zeroconf discovery for ZigStar Zigbee coordinator to ZHA Oct 22, 2021
@frenck frenck marked this pull request as draft October 22, 2021 16:16
@frenck
Copy link
Member

frenck commented Oct 22, 2021

@Hedda I've changed the PR to be draft. Please use drafts on GitHub instead of spamming PR titles with [WIP] and such. Thanks 👍

Please git rebase this PR onto the latest dev branch to deal with the unrelated build issue.

Comment on lines +88 to +93
"_zig_star_gw._tcp.local.": [
{
"domain": "zha",
"name": "zigstar*"
}
],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you have manually edited this file. Please don't.

This is a generated file. Use python -m script.hassfest to update/re-generate it.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 29, 2022
@github-actions github-actions bot closed this Feb 5, 2022
Dev automation moved this from Review in progress to Cancelled Feb 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

6 participants