Use DeviceInfo Class T-V #58445
Closed
Use DeviceInfo Class T-V #58445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdrob
requested review from
emontnemery,
frenck,
Kane610,
MartinHjelmare,
michaelarnauts,
raman325 and
rytilahti
as code owners
raman325
approved these changes
Oct 25, 2021
frenck
added
the
smash
epenet
reviewed
Oct 26, 2021
| @@ -180,27 +181,27 @@ async def async_update(self) -> None: | |||
| is_on = await self._device.get_power_state(log_api_exception=False) | |||
|
|
|||
| if is_on is None: | |||
| if self._attr_available: | |||
| if self.available: | |||
There was a problem hiding this comment.
Is this a deliberate change?
| _LOGGER.warning( | ||
| "Lost connection to %s", self._config_entry.data[CONF_HOST] | ||
| ) | ||
| self._attr_available = False | ||
| return | ||
|
|
||
| if not self._attr_available: | ||
| if not self.available: |
There was a problem hiding this comment.
Is this a deliberate change?
| "model": await self._device.get_model_name(log_api_exception=False), | ||
| "sw_version": await self._device.get_version(log_api_exception=False), | ||
| } | ||
| if not self.device_info: |
There was a problem hiding this comment.
Is this a deliberate change?
frenck
removed
the
smash
MartinHjelmare
requested changes
Oct 26, 2021
| "manufacturer": self._element.manufacturer, | ||
| "model": self._element.product, | ||
| } | ||
| return DeviceInfo( |
There was a problem hiding this comment.
Please revert all the changes that don't have tests and you haven't tested.
This was referenced Oct 28, 2021
This was referenced Oct 28, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Use DeviceInfo Class T-V
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: