Add Reauth flow to Wallbox integration #58743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdraco I added the discussed reauth flow to the wallbox component in this PR. Maybe you have time for a quick review? Thnx |
bdraco
reviewed
Oct 30, 2021
bdraco
reviewed
Oct 30, 2021
bdraco
reviewed
Oct 30, 2021
bdraco
reviewed
Oct 30, 2021
bdraco
reviewed
Oct 30, 2021
bdraco
reviewed
Oct 30, 2021
bdraco
reviewed
Oct 30, 2021
Compensating for timedrift in my devcontainer, making a new commit with the right date/time. Requested changes were done in a previous commit.
bdraco
reviewed
Nov 2, 2021
bdraco
reviewed
Nov 2, 2021
bdraco
reviewed
Nov 2, 2021
bdraco
requested changes
Nov 2, 2021
also change string for invalid serial
|
Test failure is unrelated. I'll restart the CI |
bdraco
reviewed
Nov 2, 2021
bdraco
reviewed
Nov 14, 2021
bdraco
reviewed
Nov 14, 2021
Co-authored-by: J. Nick Koston <nick@koston.org>
bdraco
approved these changes
Nov 15, 2021
natekspencer
pushed a commit
to natekspencer/home-assistant-core
that referenced
this pull request
Nov 15, 2021
* Add Reauth flow to Wallbox integration * Review comments processed * Fixed tests * Added test for reauth invalid * Commit to compensate for timedrift, show changes Compensating for timedrift in my devcontainer, making a new commit with the right date/time. Requested changes were done in a previous commit. * remove reauth schema * Update homeassistant/components/wallbox/__init__.py Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: J. Nick Koston <nick@koston.org>
| @@ -47,14 +59,27 @@ async def async_step_user(self, user_input=None): | |||
| errors = {} | |||
|
|
|||
| try: | |||
| info = await validate_input(self.hass, user_input) | |||
| await self.async_set_unique_id(user_input["station"]) | |||
There was a problem hiding this comment.
Please only wrap the lines that can raise in the try... except block.
|
|
||
| return self.async_show_form( | ||
| step_id="user", data_schema=STEP_USER_DATA_SCHEMA, errors=errors | ||
| step_id="user", | ||
| data_schema=STEP_USER_DATA_SCHEMA, |
There was a problem hiding this comment.
Normally we should only ask the user for the required info to re-authenticate in the reauth flow. We shouldn't ask the user again for info that should stay the same like station id.
| info = await validate_input(self.hass, user_input) | ||
| return self.async_create_entry(title=info["title"], data=user_input) | ||
| if user_input["station"] == self._reauth_entry.data[CONF_STATION]: | ||
| self.hass.config_entries.async_update_entry( |
There was a problem hiding this comment.
We should validate the new credentials in the reauth flow before updating the config entry data.
| @@ -7,15 +7,23 @@ | |||
| "username": "[%key:common::config_flow::data::username%]", | |||
| "password": "[%key:common::config_flow::data::password%]" | |||
| } | |||
| }, | |||
| "reauth_confirm": { | |||
There was a problem hiding this comment.
We're missing this step.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I'm adding a reauthentication flow to the wallbox component. It's triggered by an HTML 403 error (so that will usually be a password change). The flow is triggered by calling ConfigEntryAuthFailed from the authentication method of the Wallbox class.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: