Add authentication provider for Synology DSM users #58884
Conversation
MartinHjelmare
changed the title
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
The code still works with the latest version |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Code still works with latest version |
There was a problem hiding this comment.
I have been testing your PR. And in the base it works. What I am missing is a way to authorize authenticated users. All authenticated users are admin by default, that is not very useful.
Further I left some small comments. It seems your tests have not been running in the workflow.
| from homeassistant.auth import AuthProvider | ||
| from homeassistant.auth.models import Credentials, UserMeta | ||
| from homeassistant.auth.providers import AUTH_PROVIDER_SCHEMA, AUTH_PROVIDERS, LoginFlow |
There was a problem hiding this comment.
These should be relative imports
| { | ||
| vol.Required("host"): str, | ||
| vol.Required("port"): int, | ||
| vol.Required("secure", default=False): bool, |
There was a problem hiding this comment.
If this is a required option, why supply a default value?
|
My general impression is that this would allow login to home assistant using synology's authentication mechanism? I believe that extending authentication of home assistant has not been something that has been accepted in the recent past given the complexity and high bar for user expectations. e.g. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
This PR adds an authentication provider to allow users to authenticate using a Synology NAS.
Type of change
Additional information
I probably have to add some strings somewhere, but I cannot find where.
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
home-assistant/home-assistant.io#20108
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: