Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more zwave_js binary sensor descriptions #59474

Merged
merged 3 commits into from Nov 17, 2021

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Nov 10, 2021

Breaking change

  • Some binary sensor entities have been marked as diagnostic, eg lock jammed sensor, power status sensor, and system status sensor. Diagnostic entities:
    • Are, by default, not exposed to Google Assistant or Alexa.
    • Are shown on a separate card on the device configuration page.
    • Do not show up on the automatically generated Lovelace Dashboards.

Proposed change

  • Add more sensor descriptions to better categorize the binary sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@project-bot project-bot bot added this to Needs review in Dev Nov 10, 2021
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 14, 2021
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new additions look ok (i.e. they align with what is defined in https://github.com/zwave-js/node-zwave-js/blob/master/packages/config/config/notifications.json).

I am not able to test any of this in hardware though.

@viiru-
Copy link
Contributor

viiru- commented Nov 16, 2021

Looks good to me.

Copy link
Member

@marcelveldt marcelveldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

key=NOTIFICATION_SYSTEM,
states=("1", "2", "6", "7"),
states=("1", "2", "3", "4", "6", "7"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was your addition of state id's 3 and 4 intended ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, these should also work as binary sensors even if the event contains some extra parameters with failure codes.

Dev automation moved this from Needs review to Reviewer approved Nov 17, 2021
@MartinHjelmare MartinHjelmare merged commit b6dea3c into dev Nov 17, 2021
Dev automation moved this from Reviewer approved to Done Nov 17, 2021
@MartinHjelmare MartinHjelmare deleted the add-more-zwave_js-binary-sensor-descriptions branch November 17, 2021 11:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change cla-signed integration: zwave_js small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants