Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WLED reverse effect switch #59778

Merged
merged 2 commits into from Nov 20, 2021
Merged

Add WLED reverse effect switch #59778

merged 2 commits into from Nov 20, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 16, 2021

Proposed change

Add the reverse effect switch to the WLED integration.

This is the last bit that wasn't available as entity yet.
After this PR I can start removing light attributes and deprecating/removing custom services from this integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Nov 16, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Nov 16, 2021
Dev automation moved this from By Code Owner to Reviewer approved Nov 20, 2021
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 馃憤

Tested and working as expected
Screen Shot 2021-11-20 at 08 56 48

@bdraco bdraco merged commit 25f491a into dev Nov 20, 2021
@bdraco bdraco deleted the frenck-2021-3017 branch November 20, 2021 14:57
Dev automation moved this from Reviewer approved to Done Nov 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants