Yeelight disable polling

[starkillerOG]

Breaking change

Proposed change

Add a force update service to the yeelight integration.
The regular homeassistant.update_entity does not work for the yeelight integration since updates are not executed as long as the device is available (polling is turned on but if the device is available the update function emidiatly returns withouth doing the update, if the device is unavailable the update is actually executed).
This new force update service will actually update the device even if it is available.

Disable polling of the yeelight integration and let it be handeld by the upstream lib.
Make the async_update function force and update such that homeassistant.update_entity will actually get the state from the bulb.

relevant lines:

core/homeassistant/components/yeelight/__init__.py

Lines 643 to 647 in 1609c0c

	async def async_update(self, force=False):
	"""Update device properties and send data updated signal."""
	if not force and self._initialized and self._available:
	# No need to poll unless force, already connected
	return

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[probot-home-assistant]

Hey there @rytilahti, @zewelor, @shenxn, mind taking a look at this pull request as it has been labeled with an integration (yeelight) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[bdraco]

Any reason we can't make this much simpler and do

diff --git a/homeassistant/components/yeelight/__init__.py b/homeassistant/components/yeelight/__init__.py
index 1408cb5670..aea98333c0 100644
--- a/homeassistant/components/yeelight/__init__.py
+++ b/homeassistant/components/yeelight/__init__.py
@@ -700,7 +700,7 @@ class YeelightEntity(Entity):
 
     async def async_update(self) -> None:
         """Update the entity."""
-        await self._device.async_update()
+        await self._device.async_update(force=True)
 
 
 async def _async_get_device(

?

[starkillerOG]

@bdraco since polling is turned on, that would mean that the bulbs get extra update requests each scan_intervall (I don't know how many seconds).
That makes it easier for users to hit the rate-limit of 60 requests a minute, potentially causing disconnects and errors.

The polling is turnd on beacause I believe there were still some issues with older models that sometimes went unavailable and would not properly turn to available again (although that might have already been fixed, I don't know).

[bdraco]

@bdraco since polling is turned on, that would mean that the bulbs get extra update requests each scan_intervall (I don't know how many seconds). That makes it easier for users to hit the rate-limit of 60 requests a minute, potentially causing disconnects and errors.

The polling is turnd on beacause I believe there were still some issues with older models that sometimes went unavailable and would not properly turn to available again (although that might have already been fixed, I don't know).

I think we can disable polling now since the library will take care of seeing available and unavailable properly now.

[starkillerOG]

@bdraco alright, I changed it to disabling polling and setting the update to force mode.

[bdraco]

Thanks @starkillerOG 👍