Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust/Fix CI coverage reporting #60329

Merged
merged 2 commits into from Nov 25, 2021
Merged

Adjust/Fix CI coverage reporting #60329

merged 2 commits into from Nov 25, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 25, 2021

Proposed change

We are currently experiencing issues with coverage reporting on Codecov.

However, this might not be fully related to Codecov, but the new CI.

This PR adjust:

  • Remove useless dist flag from partial tests
  • Adds term missing report in partial tests, so results of these smaller suites can be viewed in the build log
  • Explicitly tell codecov the file to pick up.

The uploaded results to codecov contain anything but coverage results, looking the build logs, it seems to find a lot of file, but not the coverage file:

[2021-11-25T12:19:10.248Z] ['info'] 
     _____          _
    / ____|        | |
   | |     ___   __| | ___  ___ _____   __
   | |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
   | |___| (_) | (_| |  __/ (_| (_) \ V /
    \_____\___/ \__,_|\___|\___\___/ \_/

  Codecov report uploader 0.1.13
[2021-11-25T12:19:10.253Z] ['info'] => Project root located at: /__w/core/core
[2021-11-25T12:19:10.256Z] ['info'] -> No token specified or token is empty
[2021-11-25T12:19:11.567Z] ['info'] Searching for coverage files...
[2021-11-25T12:19:13.099Z] ['info'] => Found 16 possible coverage files:
  script/hassfest/coverage.py
  venv/bin/coverage-3.9
  venv/lib/python3.9/site-packages/coverage/htmlfiles/coverage_html.js
  venv/lib/python3.9/site-packages/sphinx/ext/coverage.py
  venv/lib64/python3.9/site-packages/coverage/htmlfiles/coverage_html.js
  venv/lib64/python3.9/site-packages/sphinx/ext/coverage.py
  venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/pydev_coverage.py
  venv/lib/python3.9/site-packages/sphinx/ext/__pycache__/coverage.cpython-39.pyc
  venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/pydev_coverage.py
  venv/lib64/python3.9/site-packages/sphinx/ext/__pycache__/coverage.cpython-39.pyc
  venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/__pycache__/pydev_coverage.cpython-39.pyc
  venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/pydev_runfiles_coverage.py
  venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/__pycache__/pydev_coverage.cpython-39.pyc
  venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/pydev_runfiles_coverage.py
  venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/__pycache__/pydev_runfiles_coverage.cpython-39.pyc
  venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/__pycache__/pydev_runfiles_coverage.cpython-39.pyc
[2021-11-25T12:19:13.099Z] ['info'] Processing /__w/core/core/script/hassfest/coverage.py...
[2021-11-25T12:19:13.102Z] ['info'] Processing /__w/core/core/venv/bin/coverage-3.9...
[2021-11-25T12:19:13.103Z] ['info'] Processing /__w/core/core/venv/lib/python3.9/site-packages/coverage/htmlfiles/coverage_html.js...
[2021-11-25T12:19:13.103Z] ['info'] Processing /__w/core/core/venv/lib/python3.9/site-packages/sphinx/ext/coverage.py...
[2021-11-25T12:19:13.104Z] ['info'] Processing /__w/core/core/venv/lib64/python3.9/site-packages/coverage/htmlfiles/coverage_html.js...
[2021-11-25T12:19:13.105Z] ['info'] Processing /__w/core/core/venv/lib64/python3.9/site-packages/sphinx/ext/coverage.py...
[2021-11-25T12:19:13.105Z] ['info'] Processing /__w/core/core/venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/pydev_coverage.py...
[2021-11-25T12:19:13.106Z] ['info'] Processing /__w/core/core/venv/lib/python3.9/site-packages/sphinx/ext/__pycache__/coverage.cpython-39.pyc...
[2021-11-25T12:19:13.107Z] ['info'] Processing /__w/core/core/venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/pydev_coverage.py...
[2021-11-25T12:19:13.107Z] ['info'] Processing /__w/core/core/venv/lib64/python3.9/site-packages/sphinx/ext/__pycache__/coverage.cpython-39.pyc...
[2021-11-25T12:19:13.108Z] ['info'] Processing /__w/core/core/venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/__pycache__/pydev_coverage.cpython-39.pyc...
[2021-11-25T12:19:13.109Z] ['info'] Processing /__w/core/core/venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/pydev_runfiles_coverage.py...
[2021-11-25T12:19:13.110Z] ['info'] Processing /__w/core/core/venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/__pycache__/pydev_coverage.cpython-39.pyc...
[2021-11-25T12:19:13.110Z] ['info'] Processing /__w/core/core/venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/pydev_runfiles_coverage.py...
[2021-11-25T12:19:13.111Z] ['info'] Processing /__w/core/core/venv/lib/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/__pycache__/pydev_runfiles_coverage.cpython-39.pyc...
[2021-11-25T12:19:13.112Z] ['info'] Processing /__w/core/core/venv/lib64/python3.9/site-packages/debugpy/_vendored/pydevd/_pydev_runfiles/__pycache__/pydev_runfiles_coverage.cpython-39.pyc...
[2021-11-25T12:19:13.291Z] ['info'] Detected GitHub Actions as the CI provider.
[2021-11-25T12:19:13.293Z] ['info'] Pinging Codecov: codecov.io/upload/v4?package=github-action-2.1.0-uploader-0.1.13&token=*******&branch=tolo-select&build=1503638895&build_url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Factions%2Fruns%2F1503638895&commit=62b577a6b936e6b284e3be731a86cce6977336af&job=CI&pr=60326&service=github-actions&slug=home-assistant%2Fcore&name=&tag=&flags=tolo&parent=
[2021-11-25T12:19:13.747Z] ['info'] Uploading...
[2021-11-25T12:19:14.002Z] ['info'] {"status":"success","resultURL":"codecov.io/github/home-assistant/core/commit/62b577a6b936e6b284e3be731a86cce6977336af"}

By pointing to the specific file, this should be resolved.

Results:

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Nov 25, 2021
@project-bot project-bot bot added this to Needs review in Dev Nov 25, 2021
@frenck frenck marked this pull request as ready for review November 25, 2021 13:50
Dev automation moved this from Needs review to Reviewer approved Nov 25, 2021
@frenck frenck merged commit 8b001fd into dev Nov 25, 2021
Dev automation moved this from Reviewer approved to Done Nov 25, 2021
@frenck frenck deleted the frenck-2021-3079 branch November 25, 2021 14:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants