Revert "Add an entity service for saving nest event related snapshots" #60632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: nest
small-pr
|
needs a PR to revert the docs too... |
|
Docs were not updated yet to incorporate this service (just merged less than 12 hours ago). However, I have started adding docs for the media source home-assistant/home-assistant.io#20380 which will stay. |
frenck
approved these changes
Nov 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #58369
The original idea was that this would coexist with a system for automatically fetching events and showing them in the media source (#60073). However after discussing offline w/ @balloob the thought is that hit seemed more interesting to just always fetch camera events and persist them to disk, which makes also providing a service not great. As a result, this will get reverted, and re-implemented internally only.